Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to google/uuid module #1423

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Conversation

mikelolasagasti
Copy link
Contributor

Current used github.com/pborman/uuid hasn't seen any updates in years.

@neolynx neolynx self-assigned this Jan 11, 2025
@neolynx neolynx added this to the 1.6.x milestone Jan 11, 2025
@neolynx neolynx self-requested a review January 11, 2025 21:05
@neolynx
Copy link
Member

neolynx commented Jan 11, 2025

thanks, that looks great !

could you also update debian/control to include the new build dependency ?

@mikelolasagasti
Copy link
Contributor Author

I think the new dep is already defined in https://github.com/aptly-dev/aptly/blob/master/debian/control#L27

@neolynx
Copy link
Member

neolynx commented Jan 11, 2025

I think the new dep is already defined in https://github.com/aptly-dev/aptly/blob/master/debian/control#L27

oh, you are right !

then we only need to remove the golang-github-pborman-uuid-dev dependency. i will then test the pure debian build...

Current used github.com/pborman/uuid hasn't seen any updates in years.

Signed-off-by: Mikel Olasagasti Uranga <[email protected]>
Copy link
Member

@neolynx neolynx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@neolynx neolynx merged commit cc32e79 into aptly-dev:master Jan 11, 2025
87 checks passed
@neolynx
Copy link
Member

neolynx commented Jan 11, 2025

purde debian build works find without that dependency 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants