Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runner): Add a custom robolectric runner which is able to manage JUnit Jupiter annotations #5

Merged
merged 4 commits into from
Mar 9, 2024

Conversation

warnyul
Copy link
Member

@warnyul warnyul commented Mar 8, 2024

Summary by CodeRabbit

  • New Features
    • Added Detekt plugin settings for project analysis.
    • Introduced a custom test runner for JUnit 5 tests with Robolectric support.
  • Bug Fixes
    • Updated JUnit 5 Robolectric test runner to handle disabled tests and parameterized tests correctly.
  • Documentation
    • Updated .gitignore to include local.properties for Android.
  • Refactor
    • Simplified method calls in JUnit5RobolectricSandboxBuilderTest.kt.
  • Chores
    • Configured project-wide group and version settings in build.gradle.
    • Enabled AndroidX support in gradle.properties.
  • Style
    • Updated Kotlin code style settings for the project.

@warnyul warnyul self-assigned this Mar 8, 2024
Copy link
Contributor

coderabbitai bot commented Mar 8, 2024

Warning

Rate Limit Exceeded

@warnyul has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 10 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 4fb9c03 and 48cd765.

Walkthrough

The project underwent significant updates covering Kotlin code style enhancements, the introduction of Detekt analysis, Gradle settings configuration, and improved testing support with JUnit 5 and Robolectric.

Changes

File(s) Change Summary
.gitignore Updated to include local.properties for Android.
.idea/codeStyles/Project.xml
.idea/detekt.xml
.idea/gradle.xml
.idea/migrations.xml
.idea/misc.xml
Various adjustments in Kotlin code style, Detekt plugin settings, Gradle configurations, and project settings.
build.gradle
gradle.properties
Set group, version, and enabled AndroidX support.
robolectric-extension/build.gradle Updated plugins, configurations, dependencies for Robolectric and JUnit 5 support.
robolectric-extension/src/main/kotlin/tech/apter/junit/jupiter/robolectric/internal/BlockJUnit4ClassRunnerExtensions.kt Added extensions for JUnit 5 compatibility.
robolectric-extension/src/main/kotlin/tech/apter/junit/jupiter/robolectric/internal/JUnit5RobolectricTestRunner.kt Introduced custom test runner for JUnit 5 with Robolectric.
robolectric-extension/src/test/kotlin/tech/apter/junit/jupiter/robolectric/internal/JUnit5RobolectricSandboxBuilderTest.kt Simplified method call in a test file.
robolectric-extension/src/test/kotlin/tech/apter/junit/jupiter/robolectric/internal/JUnit5RobolectricTestRunnerTest.kt Added test suite for custom JUnit 5 Robolectric test runner.
settings.gradle Added google() repository to pluginManagement block.

Poem

Code changes dance,
Kotlin's style gets a chance.
Robolectric and JUnit 5 unite,
Detekt analyzes, all is right.
A rabbit's joy in code's advance. 🐇


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@warnyul warnyul force-pushed the junit5-robolectric-runner branch from 5edcc48 to 48cd765 Compare March 8, 2024 21:45
@warnyul warnyul merged commit 1801863 into main Mar 9, 2024
1 check passed
@warnyul warnyul deleted the junit5-robolectric-runner branch March 9, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant