[GP-493] - Apply renaming with AMS token instead of CMS #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -240,7 +240,7 @@ typedef struct asn1_object_st | |||
| */ | |||
| #define ASN1_STRING_FLAG_NDEF 0x010 | |||
|
|
|||
| /* This flag is used by the CMS code to indicate that a string is not | |||
| /* This flag is used by the AMS code to indicate that a string is not | |||
There was a problem hiding this comment.
Please revert all changes in the external sub-folder.
The CMS in context of openssl is :
https://en.wikipedia.org/wiki/Cryptographic_Message_Syntax
There was a problem hiding this comment.
Good finding. Thanks!
I reverted all changes from external sub-folder
There was a problem hiding this comment.
There are some changes that would be nice to have earlier, like name of parameters in configuration files. But it is hard to pick only those.
I think is better to hold this change until after we do some testing.
There is one additional task which should be solved before renaming : https://arniadb.atlassian.net/browse/GP-494
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://arniadb.atlassian.net/browse/GP-493
Purpose
Describe the change
Modify Renaming tool in order on current repository "CMS" with "AMS" token.
The renaming should apply properly on existing files and folders