Adds handling for query string schema #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 97.82% 98.08% +0.26%
==========================================
Files 6 6
Lines 781 994 +213
==========================================
+ Hits 764 975 +211
- Misses 17 19 +2
Continue to review full report at Codecov.
|
Adds support for headers schema Adds more tests Abstracts out is_list_field Single quotes to double quotes Fixes tests
|
So very sorry for the enormous delays on this. I’ve been slammed with work, but I promise to take a look over the weekend. |
|
lgtm! |
|
Available on pypy in 0.17.0 |
|
Awesome, thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@apryor6 This is a first draft at addressing issues #45 and #67. Per your instructions, I've added two new arguments,
query_params_schemaandheaders_schema, which allow users to pass in marshmallow schemas for parsing query params and header values.The current behavior is as follows:
request.parsed_query_params. Unknown values are excluded.request.parsed_headers. Unknown values are excluded.reqparse.RequestParser, which allows those fields to show up in the swagger docs. Unfortunately this also means that query param and header fields will show up inrequest.parsed_args, which could be confusing. If there's a better way to get the query params and headers to show up in the swagger docs, I'd be happy to update this.Please treat this as as first pass as I'm not married to any of the implementation details — if there are better ways to implement any of this, then let me know. Once we're at a good place with the implementation, I can help update the documentation as well.