Feature: Add other schemas to @resonds #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two bugs noticed (may not be real bugs).
When no body is present (i.e. `request.get_json()` returns `None`) the schema is presented `None` to load from, whereas an empty JSON body could better be interpreted as `{}`. For a body schema with no required fields this leads to better behavior.
Error aggregation doesn't seem to have been working correctly, as `error.data['errors']` never existed, and comment "If any parsing produced an error, combine them and reraise" hints this was the intended behavior.
Exclude lines used specifically for marshmallow compatibility
# Conflicts: # dev-requirements.txt
Now works with Flask 2.2 Weukzeug 2.2 flask-restx 1.0.1
werkzeug 3.x requires python 3.8+
separated tests into logical grouping consolidated imorts
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #123 +/- ##
==========================================
- Coverage 98.35% 97.03% -1.32%
==========================================
Files 7 9 +2
Lines 1154 1416 +262
==========================================
+ Hits 1135 1374 +239
- Misses 19 42 +23 ☔ View full report in Codecov by Sentry. |
apryor6
approved these changes
Sep 17, 2024
|
Looks great, thanks for contributing! |
|
Available in latest version https://pypi.org/project/flask-accepts/#history |
|
@apryor6 Thanks for this and updating pypi Could you also bump the Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several points in #17
It adds the following
Cleaned up the tests and separated them into logical groups
updated the documenation for this new feature
updated werkzeug dependency based on python version