Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor tweaks to the cloudaccess example #54

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

KashifSaadat
Copy link
Member

No description provided.

Copy link

github-actions bot commented Jun 27, 2024

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 👮 Terraform Security Check: success
  • 🔘 Terraform Tests: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 🤖 Terraform Example Validation: success
  • 📖 Terraform Documentation: success
  • 🔖 Commitlint: success

Working Directory: modules/cloudaccess
Pusher: @KashifSaadat, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-azurerm-wayfinder/actions/runs/9693946016

Copy link

github-actions bot commented Jun 27, 2024

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 👮 Terraform Security Check: success
  • 🔘 Terraform Tests: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 🤖 Terraform Example Validation: success
  • 📖 Terraform Documentation: success
  • 🔖 Commitlint: success

Working Directory: .
Pusher: @KashifSaadat, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-azurerm-wayfinder/actions/runs/9693946016

Copy link
Member

@mrsheepuk mrsheepuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KashifSaadat KashifSaadat merged commit 99cbd6e into vnext Jun 27, 2024
22 checks passed
KashifSaadat added a commit that referenced this pull request Jun 28, 2024
* chore: update the aks nodepool to v1.29 (#47)

* fix: correct output parameter in complete example (#49)

* chore: update aks module to version 9.0.0 (#51)

Co-authored-by: Adam Smith <[email protected]>

* feat: update to wayfinder v2.7.4 (#52)

* fix: minor tweaks to the cloudaccess example (#54)

---------

Co-authored-by: Mark Hughes <[email protected]>
Co-authored-by: Adam Smith <[email protected]>
Co-authored-by: Adam Smith <[email protected]>
@KashifSaadat KashifSaadat deleted the fix-cloudaccess-example branch September 16, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants