Add role definition read, use cloudaccess submodule in install #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll need to remove from the time sleep blocks in main.tf - in fact you may need something similar in the cloudaccess submodule |
Pull Request Review Status
Pusher: @mrsheepuk, Action: |
Ha, just read this after doing it - yes, indeed, had the same thought! |
KashifSaadat
approved these changes
Oct 24, 2023
mrsheepuk
added a commit
that referenced
this pull request
Oct 25, 2023
* Add permission for roles to inspect themselves * Add delay between role definition and role assignment in cloudaccess submodule to improve reliability * Use sub-module to provision cloud access in the install * Remove now-defunct waits from main module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.