Usability improvements #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unflxw
requested review from
thijsc,
jeffkreeftmeijer,
tombruijn,
luismiramirez and
shairyar
luismiramirez
approved these changes
May 31, 2023
unflxw
force-pushed
the
usability-improvements
branch
from
ea2e01f to
31e8271
Compare
shairyar
approved these changes
May 31, 2023
tombruijn
approved these changes
May 31, 2023
shairyar
approved these changes
May 31, 2023
thijsc
approved these changes
Jun 1, 2023
When using this to test sourcemap behavior, you want to see a different revision uploaded each time, but you don't actually care what the revision name _is_, and having to set it manually to a different value in each run is mildly inconvenient. If no revision value is given, generate something that looks like a Git commit SHA with a "-fake" prefix, and use that as a revision.
This allows one to easily verify that it's configured correctly and to manually trigger sending errors.
Move automated tests dependencies (geckodriver) to the automated tests section. Clarify that `yarn` must be installed. Clarify that the Node.js version must be Node 16, using a `.tool-versions` file to set it automatically for `asdf` users.
An annoying prompt about analytics blocks the test run until it is answered. Disable it.
unflxw
force-pushed
the
usability-improvements
branch
from
31e8271 to
bdab33f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use fake revision if none given
When using this to test sourcemap behavior, you want to see a
different revision uploaded each time, but you don't actually care
what the revision name is, and having to set it manually to a
different value in each run is mildly inconvenient.
If no revision value is given, generate something that looks like
a Git commit SHA with a "-fake" prefix, and use that as a revision.
Add appsignal to the global object
This allows one to easily verify that it's configured correctly
and to manually trigger sending errors.
Improve README
Move automated tests dependencies (geckodriver) to the automated
tests section.
Clarify that
yarnmust be installed.Clarify that the Node.js version must be Node 16, using a
.tool-versionsfile to set it automatically forasdfusers.Remove Angular analytics prompt
An annoying prompt about analytics blocks the test run until it
is answered. Disable it.