Only mark a day as missing if there are less than the requested regions. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, we would mark any day with an amount of regions not equal to the monitor as missing. However the API can return 4 regions, while the monitor has 2 regions. We would mark this as missing days. This commit fixes that issue. We only consider a day as missing, if the amount of regions is less than the monitor.
matsimitsu
force-pushed
the
fix-missing-points-limited-regions
branch
from
899317b to
4dffaf6
Compare
jvanbaarsen
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, we would mark any day with an amount of regions not equal to the monitor as missing.
However the API can return 4 regions, while the monitor has 2 regions. We would mark this as missing days.
This commit fixes that issue. We only consider a day as missing, if the amount of regions is less than the monitor.