Actually publish macOS releases #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A [previous PR][oops] attempted to build macOS releases from an Ubuntu runner, which cannot possibly work. [oops]: #26 I then [attempted to do the whole build in a macOS runner][whoopsie], which also didn't work, as running Docker on macOS requires Docker Desktop. [whoopsie]: 9907bab...2ed3070 This commit follows [the agent's approach][:brain:], using a build matrix to build macOS builds on a macOS runner and Linux builds on an Ubuntu runner, then publishing it from an Ubuntu runner in a separate job. [:brain:]: https://github.com/appsignal/appsignal-agent/blob/96b5b6721804e7e15546ed6faf86348b5fa01c13/.github/workflows/publish_release.yml#L81-L100
|
Hi @unflxw, We've found some issues with your Pull Request.
|
|
Merging this so I can try it out, but I would nonetheless be interested in any feedback on how it's done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous PR attempted to build macOS releases from an Ubuntu runner, which cannot possibly work.
I then attempted to do the whole build in a macOS runner, which also didn't work, as running Docker on macOS requires Docker Desktop.
This commit follows the agent's approach, using a build matrix to build macOS builds on a macOS runner and Linux builds on an Ubuntu runner, then publishing it from an Ubuntu runner in a separate job.