Install script in release #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the installation script referenced in the README.md is the one currently available in the `main` branch. This means that, if we were to change the installation script in the `main` branch, in concordance with a different change that was not yet released, the README would point to an installation script that might not work correctly with the latest release. To fix this, make the installation script part of the release itself.
Since the installation script for each release will now be part of the release itself, it makes sense for the installation script to attempt to install the release that it was part of, rather than the latest available release.
Say "latest version" if `APPSIGNAL_WRAP_VERSION=latest`, but otherwise say "version 0.1.1". Less Yoda-esque.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards #19.
[skip changeset] -- will merge without review.
Add installation script to release
Currently, the installation script referenced in the README.md is
the one currently available in the
mainbranch. This means that,if we were to change the installation script in the
mainbranch,in concordance with a different change that was not yet released,
the README would point to an installation script that might not
work correctly with the latest release.
To fix this, make the installation script part of the release
itself.
Hardcode version number in install script
Since the installation script for each release will now be part of
the release itself, it makes sense for the installation script to
attempt to install the release that it was part of, rather than the
latest available release.
Improve install script version output
Say "latest version" if
APPSIGNAL_WRAP_VERSION=latest, butotherwise say "version 0.1.1". Less Yoda-esque.