Remove deprecated methods for gem version 3.0 #668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsimitsu
approved these changes
Nov 25, 2020
tombruijn
approved these changes
Nov 25, 2020
|
These deprecations may cause some errors people may not expect during an upgrade. So maybe it's an idea to write an upgrade guide for Ruby gem 3.0 as well? Mostly just a list of includes, extends and method calls that need to be removed from an app. |
This reverts commit 4a4cb092929e242b4530a2e6940a48c7610b7a98, as c85f39e was removed from the project tree.
jeffkreeftmeijer
force-pushed
the
3.0-deprecations
branch
from
3c0ac49 to
ba76b65
Compare
|
I’ve added writing an upgrade guide to the integrations board: https://github.com/orgs/appsignal/projects/35, and autosquashed this branch. I’ll wait with merging this until done with #603, so we can build a release. |
thijsc
approved these changes
Nov 27, 2020
This comment has been minimized.
This comment has been minimized.
9 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
thijsc
changed the title
thijsc
changed the title
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
|
While performing the daily checks some issues were found with this Pull Request.
|
|
Closing in favor of #685 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #202.
This patch removes all methods listed in the "Deprecated in 2.x”-list in #202, except for
Transaction#store, which was deprecated in #332, but wasn’t ever merged. The methods that were planned to be deprecated have been moved to #667, and will be deprecated before 4.0.