Simplify the impementation of the set_gauge helper
#223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `set_gauge` now uses OpenTelemetry's newer helper which creates a sync gauge. Our own implementation of `create_gauge` around the async OpenTelemetry's implementation has been removed in favor of the newer sync helper.
tombruijn
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
We should have a minimum version requirement on the OpenTelemetry package that introduces this new create_gauge function.
Looks like it was added here in version v1.23.0
Can you add a minimum version requirement on the API/SDK package?
Sure! :D I wanted to do this during the development of this PR. |
tombruijn
approved these changes
Aug 22, 2024
Fix OpenTelemetry API and SDK dependencies to 1.26.0 minimum so nothing breaks when using the sync gauge.
luismiramirez
force-pushed
the
update-set-gauge-helper
branch
from
afb4c98 to
536a364
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
set_gaugenow uses OpenTelemetry's newer helper, which creates a sync gauge.Our own implementation of
create_gaugearound the async OpenTelemetry's implementation has been removed in favor of the newer sync helper.Closes #220