Modify installation instructions to use import appsignal
#201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a warning emoji whenever manual instrumentation is required, that is, always. For Django's instructions, refer to the modification needed as a generic "your entrypoints" and leave it for the docs to explain further. Change other instructions to use `import appsignal`, replacing the use of `from __appsignal__ import appsignal`.
|
Hi @unflxw, We've found some issues with your Pull Request.
|
luismiramirez
approved these changes
Mar 18, 2024
unflxw
force-pushed
the
modify-installation-appsignal-start
branch
from
7cf30c7 to
256b455
Compare
jeffkreeftmeijer
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sequel to #200 that I, uh, kinda forgot to do.
Modify installation instructions
Add a warning emoji whenever manual instrumentation is required,
that is, always.
For Django's instructions, refer to the modification needed as a
generic "your entrypoints" and leave it for the docs to explain
further.
Change other instructions to use
import appsignal, replacing theuse of
from __appsignal__ import appsignal.Specify requests dependency in hook
I am not sure exactly why this change is needed now. I think Hatch
added support for specifying custom build hook dependencies
directly in the custom build hook in the last release, and this
might have accidentally broken the way in which we used to specify
this dependency.
It might also be that the breakage is intentional, in which case
they forgot to update the docs.