Skip to content

Commit

Permalink
Merge pull request #213 from appsignal/use-qualified-error-type-name
Browse files Browse the repository at this point in the history
Use qualified error type name
  • Loading branch information
unflxw authored Jun 3, 2024
2 parents fd8c78c + 9c4893d commit 5c7591d
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions tests/test_tracing.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def test_set_error(spans):
assert span.status.status_code == StatusCode.ERROR
event = span.events[0]
assert event.name == "exception"
assert event.attributes["exception.type"] == "FooError"
assert event.attributes["exception.type"] == "tests.test_tracing.FooError"
assert event.attributes["exception.message"] == "Whoops!"


Expand All @@ -126,7 +126,7 @@ def test_set_error_on_span(spans):

event = parent_span.events[0]
assert event.name == "exception"
assert event.attributes["exception.type"] == "FooError"
assert event.attributes["exception.type"] == "tests.test_tracing.FooError"
assert event.attributes["exception.message"] == "Whoops!"

child_span = next(span for span in spans if span.name == "child span")
Expand All @@ -142,7 +142,7 @@ def test_send_error(spans):

event = span.events[0]
assert event.name == "exception"
assert event.attributes["exception.type"] == "FooError"
assert event.attributes["exception.type"] == "tests.test_tracing.FooError"
assert event.attributes["exception.message"] == "Whoops!"


Expand All @@ -162,7 +162,7 @@ def test_send_error_with_current_span(spans):

event = error_span.events[0]
assert event.name == "exception"
assert event.attributes["exception.type"] == "FooError"
assert event.attributes["exception.type"] == "tests.test_tracing.FooError"
assert event.attributes["exception.message"] == "Whoops!"

assert current_span.parent is None
Expand Down Expand Up @@ -193,5 +193,5 @@ def test_send_error_with_context(spans):

event = span.events[0]
assert event.name == "exception"
assert event.attributes["exception.type"] == "FooError"
assert event.attributes["exception.type"] == "tests.test_tracing.FooError"
assert event.attributes["exception.message"] == "Whoops!"

0 comments on commit 5c7591d

Please sign in to comment.