Update span tests #586
Merged
Update span tests #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test asserts if the internal object's `trace_id` is set. This is tested in the "exposes a traceId" test already. The description of what the test says it does is covered under the "creates a Root/ChildSpan with a timestamp" test.
The span tests didn't have a case for the `setCategory` helper. I've reused the `setName` test for the `ChildSpan`. It's possible to set a "name" on a ChildSpan, but the value is ignored. It's not relevant to test this scenario.
luismiramirez
approved these changes
Feb 1, 2022
jeffkreeftmeijer
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small extraction of an attempt at a larger refactor to try something out for #556
[skip changeset]
Remove duplicate test for trace_id
This test asserts if the internal object's
trace_idis set. This istested in the "exposes a traceId" test already.
The description of what the test says it does is covered under the
"creates a Root/ChildSpan with a timestamp" test.
Add unit tests for setCategory
The span tests didn't have a case for the
setCategoryhelper.I've reused the
setNametest for theChildSpan. It's possible to seta "name" on a ChildSpan, but the value is ignored. It's not relevant to
test this scenario.