Fix extension function fallbacks #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombruijn
force-pushed
the
extension-fallbacks
branch
2 times, most recently
from
3523971 to
c62798c
Compare
tombruijn
force-pushed
the
extension-loading
branch
from
24ac4f9 to
de7b0d4
Compare
tombruijn
force-pushed
the
extension-fallbacks
branch
from
c62798c to
10cfc29
Compare
tombruijn
force-pushed
the
extension-loading
branch
from
de7b0d4 to
8fdd435
Compare
tombruijn
force-pushed
the
extension-fallbacks
branch
from
10cfc29 to
5a63030
Compare
tombruijn
force-pushed
the
extension-loading
branch
from
8fdd435 to
0af3a90
Compare
tombruijn
force-pushed
the
extension-fallbacks
branch
2 times, most recently
from
df91f1c to
b542389
Compare
tombruijn
force-pushed
the
extension-loading
branch
from
0af3a90 to
56fb794
Compare
As reported in #556, when the extension is not installed or fails to load, calls to certain extension functions will fail. The issue mentions the `runningInContainer` broken being broken on the main branch. PR #554 also removes some safety checks that cause the same issue for the `diagnoseRaw` function. Those safety checks were removed because they did not what expected, tracking if the extension was running or not. For both functions I've implemented a no-operations function. This will fix any errors on calls to these functions. Other functions that call these functions need to handle receiving no return value. Part of #556, but doesn't fix it entirely. We should call more function calls. These ones were the most obvious ones. Based on PR #554.
tombruijn
force-pushed
the
extension-fallbacks
branch
from
b542389 to
93fdc3a
Compare
3 tasks
jeffkreeftmeijer
approved these changes
Jan 19, 2022
lintje:disable MessagePresence [ci skip]
luismiramirez
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #556, when the extension is not installed or fails to
load, calls to certain extension functions will fail. The issue mentions
the
runningInContainerbroken being broken on the main branch.PR #554 also removes some safety checks that cause the same issue for
the
diagnoseRawfunction. Those safety checks were removed becausethey did not what expected, tracking if the extension was running or
not.
For both functions I've implemented a no-operations function. This will
fix any errors on calls to these functions. Other functions that call
these functions need to handle receiving no return value.
Part of #556, but doesn't fix it entirely. We should call more function
calls. These ones were the most obvious ones.
Based on PR #554.