Skip to content

Commit

Permalink
Remove duplicate test for trace_id
Browse files Browse the repository at this point in the history
This test asserts if the internal object's `trace_id` is set. This is
tested in the "exposes a traceId" test already.

The description of what the test says it does is covered under the
"creates a Root/ChildSpan with a timestamp" test.
  • Loading branch information
tombruijn committed Jan 31, 2022
1 parent e0901fd commit 30917b3
Showing 1 changed file with 0 additions and 16 deletions.
16 changes: 0 additions & 16 deletions packages/nodejs/src/__tests__/span.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,6 @@ describe("RootSpan", () => {
expect(traceId).toEqual(internal.trace_id)
})

it("exposes a start time", () => {
const { traceId } = span

expect(traceId).toBeDefined()
expect(internal.trace_id).toBeDefined()
expect(traceId).toEqual(internal.trace_id)
})

it("creates a new ChildSpan", () => {
const child = span.child()

Expand Down Expand Up @@ -142,14 +134,6 @@ describe("ChildSpan", () => {
expect(traceId).toEqual(internal.trace_id)
})

it("exposes a start time", () => {
const { traceId } = span

expect(traceId).toBeDefined()
expect(internal.trace_id).toBeDefined()
expect(traceId).toEqual(internal.trace_id)
})

it("creates a new ChildSpan", () => {
const child = span.child()

Expand Down

0 comments on commit 30917b3

Please sign in to comment.