Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code owners #485

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Update code owners #485

merged 1 commit into from
Nov 17, 2023

Conversation

jfaMan
Copy link
Contributor

@jfaMan jfaMan commented Nov 14, 2023

Change description

Feel free to rearrange if preferred.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@jfaMan jfaMan requested a review from amirtds November 14, 2023 01:36
@jfaMan jfaMan requested a review from bryanlandia as a code owner November 14, 2023 01:36
@jfaMan jfaMan self-assigned this Nov 14, 2023
@jfaMan jfaMan merged commit 03c4d4b into main Nov 17, 2023
1 of 8 checks passed
@jfaMan jfaMan deleted the ajs-update-codeowners branch November 17, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirtds amirtds amirtds approved these changes

@bryanlandia bryanlandia Awaiting requested review from bryanlandia

Assignees

@jfaMan jfaMan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfaMan @amirtds