-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump shell-quote and react-dev-utils in /frontend #466
Bump shell-quote and react-dev-utils in /frontend #466
Conversation
Bumps [shell-quote](https://github.com/substack/node-shell-quote) and [react-dev-utils](https://github.com/facebook/create-react-app/tree/HEAD/packages/react-dev-utils). These dependencies needed to be updated together. Updates `shell-quote` from 1.6.1 to 1.7.3 - [Release notes](https://github.com/substack/node-shell-quote/releases) - [Changelog](https://github.com/substack/node-shell-quote/blob/master/CHANGELOG.md) - [Commits](https://github.com/substack/node-shell-quote/compare/1.6.1...1.7.3) Updates `react-dev-utils` from 5.0.3 to 12.0.1 - [Release notes](https://github.com/facebook/create-react-app/releases) - [Changelog](https://github.com/facebook/create-react-app/blob/main/CHANGELOG-1.x.md) - [Commits](https://github.com/facebook/create-react-app/commits/[email protected]/packages/react-dev-utils) --- updated-dependencies: - dependency-name: shell-quote dependency-type: indirect - dependency-name: react-dev-utils dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…-and-react-dev-utils-1.7.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a big/breaking change. I don't think we should merge it.
This PR is doing this update, a production code dependency
This update causes version compatibility issues. PR tests are failing on Node incompatibility. To note, Figures React version is also quite out of date, running v16.5: Created an issue to track this - #468
Something to to understand clearly is how dependent Figures needs to be on front end package versions running off the edx-platform release. |
@OmarIthawi wrote
Yep. My comment above elaborates on this problem and I created a GH issue to track it |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Rejecting PR |
Bumps shell-quote and react-dev-utils. These dependencies needed to be updated together.
Updates
shell-quote
from 1.6.1 to 1.7.3Release notes
Sourced from shell-quote's releases.
Changelog
Sourced from shell-quote's changelog.
Commits
6a8a899
1.7.35799416
fix for security issue with windows drive letter regexc7de931
Add security.md414853f
Update readme.markdown (#43)0fc4a97
use Github Actions (#42)89a1993
1.7.2df7e4c7
add test for #37144e1c2
revert windows path unescaping, fixes #37c24f3aa
ci: nvs does not have iojsc2950fb
1.7.1Updates
react-dev-utils
from 5.0.3 to 12.0.1Changelog
Sourced from react-dev-utils's changelog.
... (truncated)
Commits
19fa58d
Publisha422bf2
Ensure posix compliant joins for urls in middleware (#11640)221e511
Publish3afbbc0
Update all dependencies (#11624)3880ba6
Remove dependency pinning (#11474)5cedfe4
Bump browserslist from 4.14.2 to 4.16.5 (#11476)63bba07
Upgrade jest and related packages from 26.6.0 to 27.1.0 (#11338)960b21e
Bump immer from 8.0.4 to 9.0.6 (#11364)f0a837c
Webpack 5 (#11201)369fccf
fix: fast refresh stops on needed bail outs (#11105)Maintainer changes
This version was pushed to npm by iansu, a new releaser for react-dev-utils since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.