bump version to 0.4.dev9 #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarIthawi
approved these changes
Jun 2, 2021
|
Thanks for the PR approval @OmarIthawi. But now I'm seeing tests fail, returning now too many months back, when before they were returning too few, so I need to investigate this |
|
@johnbaldwin There's a good chance that the the tests are flaky due to date timing issues. I've re-run tests, this usually fixes the issue. Anders wrote a blog about flaky date issues: |
SMM - SiteMonthlyMetrics. This one is a bit weird and I need to dig into it, I think. Tests started to fail because only 6 months back was returned for the SiteMontlyMetricsViewSet list returned. Now it is returning 7 months again, as it did before
OmarIthawi
approved these changes
Jun 3, 2021
|
@OmarIthawi It could be what you commented on above. It could also be this: #356 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.