-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Improve pinning implementation to meet spec compliance #290
Refactor: Improve pinning implementation to meet spec compliance #290
Conversation
This is awesome. Maybe not for this PR, but do you think it would be possible to include an adhoc Pinning Service Compliance check that we could put into the pipeline? |
If we are to implement this, It would require cloning the compliance repo and running the audit against a running estuary server on the pipeline. Also, the compliance team intends to add a pipeline where, as they improve the requirements and checks, it runs against pinning services prod API and notifies (creates an issue) on the service repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a great feature request. I opened ipfs-shipyard/pinning-service-compliance#140 to track it |
This PR does a refactor of the pinning implementation to make sure it is compliant with the pinning spec
NB: I have done the manual testing as well using the compliance audit tool
closes #275