Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable swift-format in CI #302

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

simonjbeaumont
Copy link
Contributor

Motivation

As part of the Github Actions CI migration we held off enabling the format check and moving to the same formatting rules as Swift NIO, but we'd like to do that now.

Modifications

  • Add a script to generate (and update) the .swiftformatignore file since this repo only wants to format a specific set of files matching a pattern.
  • Generate and commit the .swiftformatignore file.
  • Run the fomatter and commit the results.
  • Additional commits to satisfy the remaining linter rules that weren't auto-fixed by swift-format.
  • Enable the format check in CI.

Result

  • Code that's not shared is formatted with a style consistent with the other repos this team maintain.
  • CI is now checking code format again.

@simonjbeaumont simonjbeaumont changed the title Sb/GitHub actions swift format Enable swift-format in CI Nov 26, 2024
@simonjbeaumont simonjbeaumont added the semver/none No version bump required. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant