Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump targetSdkVersion from 30 to 31, and to 32 #582

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Dec 25, 2023

Lets try to use newer targetSdkVersion

AS has helpful feature to show suggestions we should fix in the upgrade. According to the hint, we should:

Screenshot 2023-12-25 at 12 34 10 PM

Screenshot 2023-12-25 at 12 34 17 PM

Bluetooth is the manifest update.

The 2nd one is https://developer.android.com/topic/performance/app-hibernation :

If your app targets Android 11 (API level 30) or higher, and the user doesn't interact with your app for a few months, the system places your app in a hibernation state. The system optimizes for storage space instead of performance, and the system protects user data. This system behavior is similar to what occurs when the user manually force-stops your app from system settings.

so maybe not related to the uia2 server.

The 3rd one is may not for the case. Possibly our settings app needs some update though.

The 4th one https://developer.android.com/about/versions/12/behavior-changes-12#notification-trampolines

To improve app performance and UX, apps that target Android 12 or higher can't start activities from services or broadcast receivers that are used as notification trampolines. In other words, after the user taps on a notification, or an action button within the notification, your app cannot call startActivity() inside of a service or broadcast receiver.

Maybe we do not have the usage to start UIA2 server from the notification regularly.

After upgrading to 31, checked 32. Then no diffs as below, so i have bumped to 32 as well.

Screenshot 2023-12-25 at 1 18 15 PM

@KazuCocoa KazuCocoa marked this pull request as ready for review December 25, 2023 21:09
@KazuCocoa
Copy link
Member Author

i have manually checked the build on my local with android 11 and 12 real devices with simple get page source, find element and send keys

@KazuCocoa KazuCocoa changed the title feat: bump targetSdkVersion to 31 feat: bump targetSdkVersion from 30 to 31, and to 32 Dec 25, 2023
@KazuCocoa KazuCocoa merged commit 1b0563a into master Dec 26, 2023
17 checks passed
@KazuCocoa KazuCocoa deleted the newer-targetversion branch December 26, 2023 01:06
github-actions bot pushed a commit that referenced this pull request Dec 26, 2023
## [5.13.0](v5.12.18...v5.13.0) (2023-12-26)

### Features

* bump targetSdkVersion from 30 to 31, and to 32 ([#582](#582)) ([1b0563a](1b0563a))
Copy link

🎉 This PR is included in version 5.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants