Feature/connectv2 with dev

[vikasrohit]

fyi @gondzo @sushilshinde @mtwomey

Let me know if we can do this merge. This is very big merge and might be causing UI issues with community site.

[maxceem]

@vikasrohit it looks like community-app doesn't use this repository, see https://github.com/topcoder-platform/community-app/blob/develop/package.json#L33-L117. Community up uses a new https://github.com/topcoder-platform/topcoder-react-ui-kit instead.

So it looks like only Connect app uses this repo. Is there any chance that any other project uses it?

If no we can safely replace dev and master branch with our feature/connectv2 branch and don't merge them.

Also, we may consider removing the components which we don't use in Connect app from react-components as there are many which look like outdated not in use anymore, like an image gallery, for example.

[maxceem]

@vikasrohit I've just noticed, that Community app uses tc-accounts which uses react-components. But tc-accounts luckily uses our Connect branch https://github.com/appirio-tech/accounts-app/blob/dev/package.json#L15

[vikasrohit]

Yep, tc-accounts started using react-components 7-8 months back when changed the registration flow for Connect and it required some components to be shared between accounts-app and connect-app.
For uses of react-components, even if community-app is not using it, there still might be few other old community side apps (e.g. topcoder-app etc) which still might be serving few pages of the overall topcoder experience. So, we need to do consolidate that list of apps where it might have been used with help of some Architect from the community side. So, lets leave it for now as is. We will take a look at it later on.

[sushilshinde]

@ThomasKranitsas please have a look

[vikasrohit]

@sushilshinde @ThomasKranitsas we created this PR to analyze the feasibility of merging and syncing the connect specific branch with standard dev/master. However, if we are not using this repo at all after introducing https://github.com/topcoder-platform/topcoder-react-utils, we can safely convert connect specific branch as dev/master and later on we can move components to the https://github.com/topcoder-platform/topcoder-react-utils when we want to have single place for all react components for topcoder.