Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FeedbackButton: Re-throw error from doSubmit #1254

Merged
merged 2 commits into from
Aug 29, 2024
Merged

FeedbackButton: Re-throw error from doSubmit #1254

merged 2 commits into from
Aug 29, 2024

Conversation

JeremyRH
Copy link
Contributor

Re-throw error from doSubmit instead of swallowing it

@JeremyRH JeremyRH requested a review from trevarmand August 29, 2024 18:09
@github-actions GitHub Actions
Copy link
Contributor

Released prerelease version 8.13.3-dont-swallow-submit-error-acc6395.0.
You may now run npm install @appfolio/react-gears@dont-swallow-submit-error

trevarmand
trevarmand approved these changes Aug 29, 2024
View reviewed changes
Copy link

@trevarmand trevarmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This would have made it easier for my team to catch an issue where we did not provide a doSubmit to this component

@JeremyRH JeremyRH merged commit 99e82e7 into master Aug 29, 2024
4 checks passed
@JeremyRH JeremyRH deleted the dont-swallow-submit-error branch August 29, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevarmand trevarmand trevarmand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeremyRH @trevarmand