Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CollapsableText): add autoAlignToggleButton prop to CollapsableText #1237

Merged
merged 1 commit into from
May 13, 2024

Conversation

mdalpozzo
Copy link
Contributor

No description provided.

Copy link

kermitapp bot commented May 9, 2024

@mdalpozzo mdalpozzo requested review from JeremyRH and arstewar May 9, 2024 23:41
@mdalpozzo mdalpozzo force-pushed the FEE-476-collapsable-text-button-align branch 2 times, most recently from bcd6ee7 to 5f99022 Compare May 10, 2024 19:57
Copy link
Contributor

@JeremyRH JeremyRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's merge it. A follow-up change can default alignToggleButton to auto. That way, if it breaks things, reverting it is no problem.

@mdalpozzo mdalpozzo force-pushed the FEE-476-collapsable-text-button-align branch from 5f99022 to d04aead Compare May 10, 2024 20:45
Copy link
Contributor

Released prerelease version 8.12.1-FEE-476-collapsable-text-button-align-a99d202.0.
You may now run npm install @appfolio/react-gears@FEE-476-collapsable-text-button-align

@mdalpozzo mdalpozzo merged commit f6e8938 into master May 13, 2024
4 checks passed
@mdalpozzo mdalpozzo deleted the FEE-476-collapsable-text-button-align branch May 13, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants