FEE-379 Update modal header to h2 for accessibility #1235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jira Issue: https://appfolio.atlassian.net/browse/FEE-379 |
Brian-Holland
force-pushed
the
boyzUpdateModalHeader
branch
2 times, most recently
from
91b1e1d to
234889b
Compare
JeremyRH
approved these changes
May 9, 2024
Brian-Holland
force-pushed
the
boyzUpdateModalHeader
branch
2 times, most recently
from
439d453 to
118d26d
Compare
Brian-Holland
force-pushed
the
boyzUpdateModalHeader
branch
from
9127c53 to
04a38f9
Compare
Brian-Holland
force-pushed
the
boyzUpdateModalHeader
branch
from
04a38f9 to
f1bae43
Compare
bump node to 20.14.0 remove yarn version because we use .yarnrc.yml
|
Released prerelease version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modal titles should be
h2so that it properly indicates the appropriate hierarchy for accessibility. We currently use ah5in our react-gears modal that is coming as the default from reactstrap.