feat(APT-1610): add portalEl prop to Combobox #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jira Issue: https://appfolio.atlassian.net/browse/APT-1610 |
|
It would be super helpful if you could add a story to the storybook, and drop a screenshot in the PR description. |
aaronmars
approved these changes
Apr 23, 2024
This allows space/position constrained implementations of combobox to render the dropdown menu in another component so the positioning of the menu is not dependent on the parent element.
chasingmaxwell
force-pushed
the
APT-1610-combobox-portal
branch
from
5b04ed0 to
363c7d6
Compare
|
@bryan-ash I've added a story and screenshots to the PR description. Thanks! |
|
Released prerelease version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This utilizes createPortal to allow space/position constrained implementations of
Comboboxto render the dropdown menu in another component so the positioning of the menu is not dependent on the parent element.In BulkUploader we need this functionality to prevent menus from being hidden behind table headers:
before: (because the dropdown menu could not be displayed outside the bounds of the table, popperjs positioned the menu on top, but it was hidden under the sticky header and couldn't be positioned above it because of the positioning of virtualized rows)
after: (using the
portalElprop we can render the dropdown menu as a child ofdocument.bodywhich allows popper to position it below and allow it to extend outside the boundary of the table regardless of the positioning of its parent row)