Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEBT-14 rg - add aria attributes to button #1194

Merged
merged 10 commits into from
Nov 28, 2023
Merged

DEBT-14 rg - add aria attributes to button #1194

merged 10 commits into from
Nov 28, 2023

Conversation

fabio-aiello-appfolio
Copy link
Contributor

Add aria attributes to button component

  • Add button role
  • Add aria-disabled attribute and set to true when button is disabled
  • Add aria-labelledby which references the text between the opening and closing tags.

@fabio-aiello-appfolio fabio-aiello-appfolio force-pushed the debt-14-rg-add-aria-attributes-to-button branch from 0f8e9e1 to 743a0fb Compare September 27, 2023 21:13
@fabio-aiello-appfolio fabio-aiello-appfolio force-pushed the debt-14-rg-add-aria-attributes-to-button branch from 01bf772 to f48f197 Compare October 25, 2023 18:53
@github-actions GitHub Actions
Copy link
Contributor

Released prerelease version 8.9.1-debt-14-rg-add-aria-attributes-to-button-8506971.0.
You may now run npm install @appfolio/react-gears@debt-14-rg-add-aria-attributes-to-button

@fabio-aiello-appfolio fabio-aiello-appfolio merged commit e44ae86 into master Nov 28, 2023
2 checks passed
@fabio-aiello-appfolio fabio-aiello-appfolio deleted the debt-14-rg-add-aria-attributes-to-button branch November 28, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronmars aaronmars aaronmars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabio-aiello-appfolio @aaronmars