fix: change ModalHeader to use h2

appfolio · Jun 24, 2024 · 0125ca6 · 0125ca6
1 parent ab4f232
commit 0125ca6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/src/components/FeedbackButton/FeedbackButton.spec.tsx b/src/components/FeedbackButton/FeedbackButton.spec.tsx
@@ -28,7 +28,7 @@ describe('<FeedbackButton />', () => {
 
     const feedbackModal = await findByRole('dialog');
 
-    const heading = within(feedbackModal).getByRole('heading', { level: 5 });
+    const heading = within(feedbackModal).getByRole('heading', { level: 2 });
     expect(heading.textContent).toEqual('Give Feedback');
 
     const ratingSubtitle = within(feedbackModal).getByText(
@@ -129,7 +129,7 @@ describe('<FeedbackButton />', () => {
 
     const feedbackModal = await findByRole('dialog');
 
-    const heading = within(feedbackModal).getByRole('heading', { level: 5 });
+    const heading = within(feedbackModal).getByRole('heading', { level: 2 });
     expect(heading.textContent).toEqual('Give Feedback2');
 
     const ratingSubtitle = within(feedbackModal).getByText(
@@ -217,7 +217,7 @@ describe('<FeedbackButton />', () => {
 
     const feedbackModal = await findByRole('dialog');
 
-    const heading = within(feedbackModal).getByRole('heading', { level: 5 });
+    const heading = within(feedbackModal).getByRole('heading', { level: 2 });
     expect(heading.textContent).toEqual('Give Feedback');
 
     const feedbackModalRating = within(feedbackModal).getByTestId('feedback-modal-rating');
@@ -293,7 +293,7 @@ describe('<FeedbackButton />', () => {
 
     const feedbackModal = await findByRole('dialog');
 
-    const heading = within(feedbackModal).getByRole('heading', { level: 5 });
+    const heading = within(feedbackModal).getByRole('heading', { level: 2 });
     expect(heading.textContent).toEqual('Give Feedback');
 
     within(feedbackModal).getByText('How could we improve the way this works for you?');
@@ -346,7 +346,7 @@ describe('<FeedbackButton />', () => {
 
     const feedbackModal = await findByRole('dialog');
 
-    const heading = within(feedbackModal).getByRole('heading', { level: 5 });
+    const heading = within(feedbackModal).getByRole('heading', { level: 2 });
     expect(heading.textContent).toEqual('Give Feedback');
 
     within(feedbackModal).getByText('How could we improve the way this works for you?');

diff --git a/src/components/Modal/ModalHeader.tsx b/src/components/Modal/ModalHeader.tsx
@@ -1,3 +1,6 @@
-import { ModalHeader } from 'reactstrap';
+import React from 'react';
+import { ModalHeader as RsModalHeader } from 'reactstrap';
+
+const ModalHeader = ({ ...props }) => <RsModalHeader tag="h2" {...props} />;
 
 export default ModalHeader;