Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8.0 explicity in starter.ini #204

Open
apolopena opened this issue Mar 1, 2022 · 2 comments
Open

Support PHP 8.0 explicity in starter.ini #204

apolopena opened this issue Mar 1, 2022 · 2 comments
Labels
enhancement New feature or request passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main

Comments

@apolopena
Copy link
Owner

apolopena commented Mar 1, 2022

Problem this feature will solve

A user should be able to specify PHP 8.0 explicitly in starter.ini rather than relying on the value gitpodlatest to do the job.
Also once Gitpod bumps their PHP version up past 8.0. Users will need to be able to explicitly set PHP 8.0 in starter.ini

Background

Proposed Solution

Support 8.0 as a value for version in [PHP] in starter.ini

Constraints and Assumptions

Alternatives or Workarounds

Additional context

Add any other context or screenshots about the feature request here.

@apolopena apolopena added enhancement New feature or request in-development Bug or feature is currently being worked on in-dev-qa and removed in-development Bug or feature is currently being worked on labels Mar 1, 2022
apolopena added a commit that referenced this issue Mar 1, 2022
@apolopena apolopena added this to the v1.6 release 🚀 milestone Mar 3, 2022
apolopena added a commit that referenced this issue Mar 4, 2022
@apolopena apolopena added passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main and removed in-dev-qa labels Mar 5, 2022
@strausmann
Copy link
Contributor

Shouldn't the whole thing just be kept dynamic so that you could also install PHP 8.1, for example?
It is clear to me that PHP 8.0 and 8.1 are very rarely used.

@apolopena
Copy link
Owner Author

apolopena commented Mar 6, 2022

Since there is a potential purge of the existing (gitpod) PHP before the install It is like half dynamic ATM. Only versions 'supported' in starter.ini can be used because the PPA's and packages that get installed are different per PHP version so those need to be hardcoded in .gp/bash/php.sh
also apache might need different treatment in an upcoming PHP release. We would still need to error handle invalid PHP versions such as 22.4 etc....

So this is why I have half the system hardcoded.
Perhaps we can think of a better way...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main
Projects
None yet
Development

No branches or pull requests

2 participants