php-fpm is not installed when using 'gitpodlatest' for the PHP version in starter.ini #203
Labels
bug
Something isn't working
passed-dev-qa
Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main
Milestone
Describe the bug
When using the existing installation of PHP in
gitpod/workspace-mysql
,php-fpm
is not installed so PHP does not work with nginx out of the box. This breaks the demo flow when nginx is the default server (which currently is the default instarter.ini
).Screenshots
Steps to reproduce
gitpod-laravel-starter
with 'gitpodlatest' set for the PHP version instarter.ini
Expected behavior
Ideally
php-fpm
would be installed as part ofgitpod/workspace-mysql
. There is a question there in a PR that rasies this thought.At a minimum
php-fpm
must be installed inphp.sh
when the existing Gitpod installation of PHP is left as-is.This will of course need to be removed if Gitpod decides to includes
php-fpm
ingitpod/workspace-mysql
We could sniff for the
php-fpm
installation and act accordingly but I would rather not introduce that complexity.Additional information
I decided to go with sniffing out the
php-fpm
install and dynamically installing it if it wasn't already installed.The text was updated successfully, but these errors were encountered: