-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update/annotate formerly experimental configs #5938
Conversation
@Meschreiber, please consider creating a changeset entry in |
CI performance tests
|
<Note> | ||
|
||
Beginning with [v1.49.0](https://github.com/apollographql/router/releases/tag/v1.49.0), the router supported enhanced operation signature normalization [experimentally](/resources/product-launch-stages/#experimental-features). | ||
In [v.1.53.0](https://github.com/apollographql/router/releases/tag/v1.53.0), this configuration became [generally available](/resources/product-launch-stages/#general-availability). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config rename will happen in v1.54.0, so we should use that as the version it became GA (and not merge this until then).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is merging into dev, so I think we can/should merge before the release, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! We'll start 1.54.0 (as a release candidate) today and this will not land in our docs until next Tuesday when we finalize 1.54.0. 😄 I'll merge this to make sure it makes the cut. (It looks like the version was already raised to 1.54.0 in the text, which is totes right.)
This PR removes the
<ExperimentalFeature>
annotation for two configs that are no longer experimental and adds a note for when they became generally available. I considered adding the following text to the note, but found it unnecessary.Happy to add it back if others deem it's helpful.
See #5807 for more info.