Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve entity cache tests #5894

Closed
wants to merge 1 commit into from
Closed

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Aug 27, 2024

placeholder for now, testing subgraph request id behaviour with rhai


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

this will require exposing the cache keys
@Geal Geal force-pushed the geal/improve-entity-cache-tests branch from c868e29 to 540d5da Compare October 24, 2024 08:29
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Oct 24, 2024

✅ Docs Preview Ready

No new or changed pages found.

Copy link
Contributor

@Geal, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@Geal
Copy link
Contributor Author

Geal commented Oct 24, 2024

not needed anymore

@Geal Geal closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants