Do not report usage to Studio when variable values are invalid

apollo-router/src/services/supergraph/service.rs

@@ -169,7 +169,7 @@ async fn service_call(
 ) -> Result<SupergraphResponse, BoxError> {
     let context = req.context;
     let body = req.supergraph_request.body();
-    let variables = body.variables.clone();
+    let variables = &body.variables;
 
     let QueryPlannerResponse {
         content,
@@ -304,6 +304,15 @@ async fn service_call(
                 *response.response.status_mut() = StatusCode::NOT_ACCEPTABLE;
                 Ok(response)
             } else if let Some(err) = plan.query.validate_variables(body, &schema).err() {
+                // Replace the existing usage report so we do not report invalid variable values to
+                // Studio.
+                context.extensions().with_lock(|mut lock| {
+                    lock.insert(Arc::new(UsageReporting {
+                        stats_report_key: "GRAPHQL_VALIDATION_FAILED".to_string(),
+                        referenced_fields_by_type: Default::default(),
+                    }))
+                });
+
                 let mut res = SupergraphResponse::new_from_graphql_response(err, context);
                 *res.response.status_mut() = StatusCode::BAD_REQUEST;
                 Ok(res)