Skip to content

Commit

Permalink
Revert "(fix) Prevent Datadog timeout errors in logs (#5692)"
Browse files Browse the repository at this point in the history
This reverts commit c460962.
  • Loading branch information
BrynCooke authored Jul 26, 2024
1 parent 51a4494 commit 0b7f373
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 20 deletions.
12 changes: 0 additions & 12 deletions .changesets/fix_bryn_datadog_timeout.md

This file was deleted.

9 changes: 1 addition & 8 deletions apollo-router/src/plugins/telemetry/tracing/datadog.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
use std::fmt::Debug;
use std::fmt::Formatter;
use std::time::Duration;

use ahash::HashMap;
use ahash::HashMapExt;
Expand Down Expand Up @@ -197,13 +196,7 @@ impl TracingConfigurator for Config {
.expect("cargo version is set as a resource default;qed")
.to_string(),
)
.with_http_client(
reqwest::Client::builder()
// https://github.com/open-telemetry/opentelemetry-rust-contrib/issues/7
// Set the idle timeout to something low to prevent termination of connections.
.pool_idle_timeout(Duration::from_millis(1))
.build()?,
)
.with_http_client(reqwest::Client::builder().build()?)
.with_trace_config(common)
.build_exporter()?;

Expand Down

0 comments on commit 0b7f373

Please sign in to comment.