Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add type for experimentalFragmentVariables #230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: add type for experimentalFragmentVariables #230

wants to merge 1 commit into from

Conversation

Quramy
Copy link

@Quramy Quramy commented Jan 7, 2019

I found #167 but the TS definitions of enableExperimentalFragmentVariables and disableExperimentalFragmentVariables was not found.

JoviDeCroock
JoviDeCroock approved these changes Jan 27, 2019
View reviewed changes
Copy link

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, will probably be covered in #235 though

@sgarner
Copy link

sgarner commented Jun 2, 2019

Since #235 looks like quite a major change and might be some time away - could this extremely minor change please be merged in for now, so that the experimental fragment variables feature can be used from TS?

@zyqxd
Copy link

zyqxd commented Sep 20, 2019

@JoviDeCroock Any movement on this? #235 is closed, and the type is still missing
ref issues #252 and #228

@jaytolentino
Copy link

jaytolentino commented Oct 7, 2019 •
edited
Loading

+1 on this, also getting errors for the missing types. Any updates?

@k41n
Copy link

k41n commented Jan 14, 2020

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Quramy @sgarner @zyqxd @jaytolentino @k41n @JoviDeCroock