[Loader] Fix: Track refs to NonNullType #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnwng
force-pushed
the
master
branch
3 times, most recently
from
7fd462d to
8b34c3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I spent yesterday updating the beta branch of my package babel-plugin-inline-import-graphql-ast to support multiple operations like this package. In doing so, I reused a lot of the code from here and noticed that nullable variables were being tracked but non-nullable variables were not. I assume that was not the intention.
I haven't added a test because I'm not familiar with your test configuration (or webpack in general) and didn't see any existing tests covering the variable reference tracking (which is why I'm assuming this slipped through in the first place). If someone can give me any pointers I'm willing to attempt to make some tests.
I've tested it manually in my project and verified that without this code, the Set() will not contain names for non-nullable variables, and with this code it will.