Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

65 generowanie listy komentarzy #405

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

65 generowanie listy komentarzy #405

wants to merge 15 commits into from

Conversation

sylviacapella
Copy link

#65

apohllo
apohllo reviewed Mar 2, 2016
View reviewed changes
spec/features/submissions_spec.rb
click_on("Data nadesłania")
expect(page).to have_content(/11-01-2016.*19-01-2016/)
click_on("Data nadesłania")
expect(page).to have_content(/19-01-2016.*11-01-2016/)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brakuje end

apohllo
apohllo reviewed Mar 3, 2016
View reviewed changes
app/controllers/issues_controller.rb
@@ -58,6 +58,7 @@ def update

def show
@issue = Issue.find_by_volume(params[:id])
@article_revisions = ArticleRevision.joins(:submission).where(submissions: { issue: id })
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: params[:id]

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choć mam spore wątpliwości odnośnie tego czy to jest potrzebne.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To powinno być w osobnej akcji show_comments zdefiniowanej w tym kontrolerze. Na wzór akcji takich jak show_reviews etc.

@apohllo
Copy link
Owner

apohllo commented Mar 4, 2016

Musi być jeszcze wpis w routes.rb na wzór wpisów show_reviews itp.

@sylviacapella
Copy link
Author

Szanowny Panie ,

czy mogłabym dostać 1 punkt za to zadanie? Wiem, że nie jest dokończone ale
chociaż za wkład czasu.

Pozdrawiam

W dniu piątek, 4 marca 2016 Aleksander Smywiński-Pohl <
[email protected]> napisał(a):

Musi być jeszcze wpis w routes.rb na wzór wpisów show_reviews itp.

—
Reply to this email directly or view it on GitHub
#405 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylviacapella @apohllo