Add Text Align option #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apognu
requested changes
May 2, 2024
|
I added a few comments. Also, thank you for not shoehorning this into the theme string. Even if that might be a good idea long-term, it needs some thinking on my part. 😁 |
apognu
requested changes
May 2, 2024
Greet align matches to exact case now, not coaxing the string into upper/lower case
dthelegend
commented
May 13, 2024
apognu
requested changes
May 13, 2024
apognu
approved these changes
May 13, 2024
|
Merged! Thanks you for the PR. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I added a text-align option to the prompt. I did this mainly so ASCII art I had in my
/etc/issueshowed up better, but I can see it being useful for other things as well.I am not sure if you would rather include this in the new theme flag I saw recently added, but I wasn't sure how to properly extend the format to accommodate that so I added it as a new flag. Leaving the flag absent defaults to center align as before.