Fail linting on warnings.

apognu · Oct 17, 2024 · ed7f494 · ed7f494
1 parent 754c25f
commit ed7f494
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 14 deletions.
diff --git a/.github/workflows/dev.yml b/.github/workflows/dev.yml
@@ -14,8 +14,8 @@ jobs:
       - uses: Swatinem/rust-cache@v2
       - name: Lint
         run: |
-          cargo clippy
-          cargo clippy --release
+          cargo clippy -D warnings
+          cargo clippy --release -- -D warnings
 
   test:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -14,8 +14,8 @@ jobs:
       - uses: Swatinem/rust-cache@v2
       - name: Lint
         run: |
-          cargo clippy
-          cargo clippy --release
+          cargo clippy -D warnings
+          cargo clippy --release -- -D warnings
 
   test:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -14,8 +14,8 @@ jobs:
       - uses: Swatinem/rust-cache@v2
       - name: Lint
         run: |
-          cargo clippy
-          cargo clippy --release
+          cargo clippy -D warnings
+          cargo clippy --release -- -D warnings
 
   test:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/tip.yml b/.github/workflows/tip.yml
@@ -14,8 +14,8 @@ jobs:
       - uses: Swatinem/rust-cache@v2
       - name: Lint
         run: |
-          cargo clippy
-          cargo clippy --release
+          cargo clippy -D warnings
+          cargo clippy --release -- -D warnings
 
   test:
     runs-on: ubuntu-latest

diff --git a/src/ui/mod.rs b/src/ui/mod.rs
@@ -20,18 +20,14 @@ use sessions::SessionSource;
 use tokio::sync::RwLock;
 use tui::{
   layout::{Alignment, Constraint, Direction, Layout},
-  style::{Modifier, Style},
+  style::Modifier,
   text::{Line, Span},
   widgets::Paragraph,
   Frame as CrosstermFrame, Terminal,
 };
 use util::buttonize;
 
-use crate::{
-  info::capslock_status,
-  ui::util::{should_hide_cursor, titleize},
-  Greeter, Mode,
-};
+use crate::{info::capslock_status, ui::util::should_hide_cursor, Greeter, Mode};
 
 use self::common::style::{Theme, Themed};
 pub use self::i18n::MESSAGES;