Merge pull request #4 from apoex/17493-use-faraday

[#17493] Use faraday

README.md

@@ -37,7 +37,6 @@ How to fetch a package with the test identifier from [developer documentation](h
 ```ruby
 > response = Postnord.find_by_identifier('84971563697SE')
 > response.code # => 200
-> response.status # => OK
 > response.data # => {"TrackingInformationResponse"=>{"shipments"=>[]}}
 ```
 

lib/postnord.rb

@@ -1,6 +1,5 @@
+require 'faraday'
 require 'uri'
-require 'net/http'
-require 'net/https'
 require 'json'
 require 'openssl'
 

lib/postnord/client.rb

@@ -18,11 +18,8 @@ def do_request(service, endpoint, params={})
       )
 
       uri.query = URI.encode_www_form(params)
-      req = Net::HTTP::Get.new(uri)
 
-      res = Net::HTTP.start(uri.hostname, uri.port, use_ssl: uri.scheme == 'https') do |http|
-        http.request(req)
-      end
+      res = Faraday.get(uri)
 
       Response.new(res)
     end

lib/postnord/response.rb

@@ -2,18 +2,13 @@ module Postnord
   class Response
     def initialize(data)
       @data = data
-      @code = data.code
-      @status = data.msg
+      @code = data.status
     end
 
     def code
       @data.code
     end
 
-    def status
-      @data.status
-    end
-
     def data
       JSON.parse(@data.body)
     rescue JSON::ParserError
@@ -23,7 +18,6 @@ def data
     def to_h
       {
         code: @code,
-        status: @status,
         data: data,
       }
     end

lib/postnord/version.rb

@@ -1,3 +1,3 @@
 module Postnord
-  VERSION = "0.2.3"
+  VERSION = "0.3.0"
 end

postnord.gemspec

@@ -18,6 +18,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
+  spec.add_dependency 'faraday'
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake", ">= 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"