Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add a view for all the submissions within a course #1431

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

James-Leste
Copy link
Contributor

@James-Leste James-Leste commented Dec 20, 2024

Description

What?

Added a view for viewing all the submissions within a course, with tag filtering enabled

Screen.Recording.2024-12-20.at.9.45.32.AM.mp4

Why?

It is a highly required feature.

How?

Add and linkedAllSubmissionsView and all_exercise_submissions.html

Fixes #1408

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

@James-Leste James-Leste self-assigned this Dec 20, 2024
@James-Leste James-Leste marked this pull request as ready for review December 20, 2024 10:58
@James-Leste James-Leste force-pushed the all_submission branch 4 times, most recently from fa0e867 to ce16f28 Compare December 20, 2024 11:56
Copy link
Contributor

@ihalaij1 ihalaij1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

I made some minor fixes and stylistic changes.

@ihalaij1 ihalaij1 merged commit 35fef98 into apluslms:master Jan 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add a view for browsing submissions with submission tags
3 participants