Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to previous page when cancelling new deadline deviation #1301

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

ihalaij1
Copy link
Contributor

Description

What?

Previously, the cancel button always sent the user to the deadline deviation list page. Now, it sends the user to the page where they came from, if possible.

Why?

This was requested by a teacher.

Fixes #1278

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

Tested that redirection works after cancelling new deadline deviation on inspect submission page and user results page.

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

Copy link
Contributor

@PasiSa PasiSa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I did not test this, but I assume you did.

@PasiSa PasiSa assigned ihalaij1 and unassigned markkuriekkinen Nov 14, 2023
Previously, the cancel button always sent the user to
the deadline deviation list page. Now, it sends the user
to the page where they came from, if possible.

Fixes apluslms#1278
@ihalaij1 ihalaij1 removed the request for review from markkuriekkinen November 16, 2023 12:52
@ihalaij1 ihalaij1 merged commit d85705c into apluslms:master Nov 16, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

The Cancel button in Add Deadline Deviations behaves surprisingly
3 participants