Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The module search under add deadline deviations is case sensitive #1295

Conversation

ashi006
Copy link
Contributor

@ashi006 ashi006 commented Oct 24, 2023

Fixes #1280

Description

What?

In add deadline deviations form, the module field search was case sensitive.

Why?

getSearchResults(() function in ajax_search_select.js was using the default :contains (which is case sensitive) selector to select the module value.

How?

Defined a custom selector "icontains" in ajax_search_results.js file to select elements that contain a specific text substring, case-insensitively and replaced :contains with :icontains in getSearchResults().

Fixes #1280

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

@ihalaij1 ihalaij1 self-requested a review October 31, 2023 11:24
@ihalaij1 ihalaij1 self-assigned this Oct 31, 2023
Copy link
Contributor

@ihalaij1 ihalaij1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

See the single question that I had.

assets/js/ajax_search_select.js Outdated Show resolved Hide resolved
@ihalaij1 ihalaij1 assigned ashi006 and unassigned ihalaij1 Nov 3, 2023
@ashi006 ashi006 force-pushed the Issue-1280-the-module-search-under-add-deadline-deviations-is-case-sensitive branch from 0abc5a5 to 22328d3 Compare November 14, 2023 10:41
@ihalaij1
Copy link
Contributor

Great, thank you!

@ihalaij1 ihalaij1 force-pushed the Issue-1280-the-module-search-under-add-deadline-deviations-is-case-sensitive branch from 22328d3 to fde2485 Compare November 20, 2023 14:16
@ihalaij1 ihalaij1 force-pushed the Issue-1280-the-module-search-under-add-deadline-deviations-is-case-sensitive branch from fde2485 to 57e0951 Compare November 20, 2023 14:18
@ihalaij1
Copy link
Contributor

I updated the commit message to include an empty newline before the Fixes #1280.

@ihalaij1 ihalaij1 merged commit 115687c into apluslms:master Nov 20, 2023
8 checks passed
@ashi006 ashi006 deleted the Issue-1280-the-module-search-under-add-deadline-deviations-is-case-sensitive branch November 30, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

The module search under Add Deadline Deviations is case sensitive
2 participants