Bug/$comment base64 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arosenb2
requested changes
Jan 18, 2024
|
@DavidBiesack I think you can also attach Issue #14 to this PR to automatically close that when this is merged. |
…-down-convert into bug/$comment-base64
arosenb2
reviewed
Jan 19, 2024
arosenb2
approved these changes
Jan 19, 2024
arosenb2
approved these changes
Jan 19, 2024
arosenb2
approved these changes
Jan 19, 2024
arosenb2
approved these changes
Jan 19, 2024
|
merging, bypassing the branch permissions, because Aaron has approved the PR (and is a repo member with Triage role). GitHub still says "At least 1 approving review is required by reviewers with write access." but I don't know what else to change so that Aaron's approval is an "approving review".... |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13 (basic cases)
fixes #14