only look for operation children (HTTP methods) of a path

apiture · Apr 22, 2024 · 58358a8 · 58358a8
1 parent 7a0d3fa
commit 58358a8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/converter.ts b/src/converter.ts
@@ -385,7 +385,7 @@ export class Converter {
       for (const path in paths) {
         // filter out path.{$ref, summary, description, parameters, servers} and x-* specification extensions
         const methods = Object.keys(paths[path]).filter((op) => Converter.METHODS.includes(op));
-        for (const method in methods) {
+        methods.forEach(method => {
           const operation = paths[path][method];
           const sec = (operation?.security || []) as object[];
           sec.forEach((s) => {
@@ -396,7 +396,7 @@ export class Converter {
               });
             }
           });
-        }
+        });
       }
       return scopes;
     };

diff --git a/test/converter.spec.ts b/test/converter.spec.ts
@@ -773,8 +773,8 @@ describe('resolver test suite', () => {
     const scopes = converted.components.securitySchemes.accessToken.flows.authorizationCode.scopes;
     expect(scopes['scope1']).toEqual('Allow the application to access your personal profile data.');
     expect(scopes['scope3']).toEqual(`TODO: describe the 'scope3' scope`);
-    const unauthOp = (converted.paths['/users/{appId}/open-preferences'] as object)['get'];
-    expect(unauthOp['security']).toBeFalsy();
+    const publicOp = (converted.paths['/users/{appId}/public-preferences'] as object)['get'];
+    expect(publicOp['security']).toBeFalsy();
     done();
   });
 });

diff --git a/test/data/openapi.yaml b/test/data/openapi.yaml
@@ -94,7 +94,7 @@ paths:
             - scope2
             - scope3
             - scope4
-  /users/{appId}/open-preferences:
+  /users/{appId}/public-preferences:
     parameters:
       - $ref: '#/components/parameters/appIdPathParam'
     get: