Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix the Hero section tagline colors #2757

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Nov 29, 2024

The inbuilt Docusaurus CSS minifier doesn't respect the CSS descendant combinator (likely treats it as an unused style and removes it from the build). This shows both with the nested CSS and the classic a b syntax. While related CSS issues (e.g. facebook/docusaurus#9303) are already known to the Docusaurus team, this one still shows in the latest version ([email protected]).

This PR adds a separate CSS class for the transparent words in the tagline and explicitly sets this class on the relevant elements

obrazek

@barjin barjin added documentation Improvements or additions to documentation. adhoc Ad-hoc unplanned task added during the sprint. labels Nov 29, 2024
@barjin barjin self-assigned this Nov 29, 2024
@github-actions github-actions bot added this to the 103rd sprint - Tooling team milestone Nov 29, 2024
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 29, 2024
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duh, locally it worked, forgot to check it after deploy, thanks!

@barjin barjin merged commit 30d0bf8 into master Nov 29, 2024
9 checks passed
@barjin barjin deleted the docs/fix-hero-colors branch November 29, 2024 11:03
@slorber
Copy link

slorber commented Nov 29, 2024

Hey

If you still have bugs in the latest version that we are not aware of, please report them 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. documentation Improvements or additions to documentation. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants