-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on 4th time this check is evaluated, it throws an undefined #128
Conversation
Hi @minoseah629 Thanks for reporting this. Could you share which version of K6 you are using? |
ill share this was a problem prior to running any k6 command: k6.exe v0.51.0 (commit/33d3caa7d1, go1.22.3, windows/amd64) |
Would it be possible to share how to reproduce the issue? |
Your PR looks good since it improves the JavaScript safety with the optional chaining, but it is strange that exec becomes undefined. |
i cannot share the exact postman collection json. I have exported my postman collection yesterday. this is what I observed:
|
@minoseah629 Thanks again for sharing this detailed info and the screenshots. It will allow us to rebuild a Postman collection to reproduce the mentioned cases and add some tests to cover this from the future. Give me a bit of time to process this all and reproduce it, that will allow your PR to land properly and covered. |
sounds good. sorry for not generating unit tests. i am not good with javascript compared to c# experience. |
@minoseah629 I was not expecting unit tests, I'm already very happy with all your input and the PR. |
I have not been able to reproduce it, but the PR changes are useful for a safer JS. Did it solve your problem? |
hi @minoseah629 We just released v1.10.0 of postman-to-k6 cli. Thanks for your contribution. Let me know if your issue is resolved or still occurring. |
1
2
3
4